Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AI Tools #4505

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Fix AI Tools #4505

merged 2 commits into from
Mar 25, 2022

Conversation

amteusch
Copy link
Contributor

@amteusch amteusch commented Mar 23, 2022

Motivation and context

Pretty simple changes should fix #4432

How has this been tested?

Only tested by building locally, following instructions from here. DEXTR
Screenshot from 2022-03-23 16-37-35
and YOLOv3
Screenshot from 2022-03-23 16-36-58
worked but these are the only ones I tried. On Ubuntu 20.04.4. Please advise about tests and change log, I did not do either of these from the checklist but I'm not sure if they are needed for this small fix

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@amteusch amteusch requested a review from nmanovic as a code owner March 23, 2022 22:56
@nmanovic
Copy link
Contributor

@amteusch , thanks for the contribution. We will add a test on our side. Could you please add a line to CHANGELOG.md?

@amteusch
Copy link
Contributor Author

@nmanovic added the line but I think I didn't rebase properly... let me know what needs fixing

@nmanovic
Copy link
Contributor

@amteusch , could you please merge our develop branch into your branch? You should have only 2 files in 'Files changed'.

@amteusch
Copy link
Contributor Author

@nmanovic better?

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amteusch , thanks for the great contribution! We will add a test to avoid such issues in the future.

@nmanovic nmanovic merged commit eb63420 into cvat-ai:develop Mar 25, 2022
@nmanovic
Copy link
Contributor

@ivk , could you please prepare a regression test for issue? Please work with @kirill-sizov to implement a way to test serverless functions.

@amteusch
Copy link
Contributor Author

I just installed cvat a few hours ago, and the fix does not seem to work. I still don't get a polygon, as in #4432, both with DEXTR and HRnet.

FYI, I checked my cvat/apps/lambda_manager/views.py and it contains the fix in this PR.

Have you installed the nuclio tool? I found I needed to follow additional instructions for the fix to work properly.

Not ruling out the possibilty of a bug, but maybe this could help narrow down the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI tools Interactors no polygon output
3 participants