Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pascal_voc import bug #4647

Merged
merged 22 commits into from
Nov 8, 2022
Merged

fix pascal_voc import bug #4647

merged 22 commits into from
Nov 8, 2022

Conversation

ftconan
Copy link
Contributor

@ftconan ftconan commented May 19, 2022 •
edited by yasakova-anastasia
Loading

Motivation and context

Fixed #4621

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues 4621
  • I have increased versions of npm packages if it is necessary (cvat-canvas,
    cvat-core, cvat-data and cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max
Copy link
Contributor

Hi! Thank you for the PR. Could you also add a test and describe the specific problem this PR resolves?

@ftconan
Copy link
Contributor Author

ftconan commented Aug 22, 2022

  1. If the folder contains only images and PASCAL VOC1.1 XML and does not follow the CVAT export standard format, the project will report an error in the import data set
  2. Both .jpg and .jpeg formats are supported

@ftconan
Copy link
Contributor Author

ftconan commented Aug 22, 2022

截屏2022-08-22 18 06 29

@ftconan
Copy link
Contributor Author

ftconan commented Aug 22, 2022

task#109-fisheyes_yolov5_test_task-2022_06_29_09_44_32-pascal voc 1.1-.zip

@bsekachev
Copy link
Member

@zhiltsov-max Do you think the PR is ready?

zhiltsov-max
zhiltsov-max requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem reasonable to me, but I'd like to see at least 2 tests for these changes - for the background class and for image moving.

@yasakova-anastasia
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@yasakova-anastasia
Copy link
Contributor

Changes seem reasonable to me, but I'd like to see at least 2 tests for these changes - for the background class and for image moving.

Added tests

SpecLad
SpecLad reviewed Oct 25, 2022
View reviewed changes
tests/python/rest_api/test_projects.py Outdated Show resolved Hide resolved
tests/python/rest_api/test_projects.py Outdated Show resolved Hide resolved
tests/python/rest_api/test_projects.py Outdated Show resolved Hide resolved
tests/python/rest_api/test_projects.py Outdated Show resolved Hide resolved
tests/python/rest_api/test_projects.py Outdated Show resolved Hide resolved
@cvat-ai cvat-ai deleted a comment from github-actions bot Oct 26, 2022
@yasakova-anastasia
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@yasakova-anastasia
Copy link
Contributor

@ftconan
Could you please tell me how you got this dataset? I would like to understand why such a generalization is needed.

@cvat-ai cvat-ai deleted a comment from github-actions bot Oct 31, 2022
@yasakova-anastasia
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

SpecLad
SpecLad reviewed Nov 1, 2022
View reviewed changes
cvat/apps/dataset_manager/bindings.py Outdated Show resolved Hide resolved
tests/python/rest_api/test_projects.py Outdated Show resolved Hide resolved
@yasakova-anastasia
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

SpecLad
SpecLad approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@SpecLad SpecLad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor issue.

tests/python/rest_api/test_projects.py Show resolved Hide resolved
@bsekachev bsekachev merged commit 0b7fb04 into cvat-ai:develop Nov 8, 2022
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasakova-anastasia yasakova-anastasia yasakova-anastasia left review comments

@SpecLad SpecLad SpecLad approved these changes

@zhiltsov-max zhiltsov-max zhiltsov-max approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

@nmanovic nmanovic Awaiting requested review from nmanovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: PASCAL VOC 1.1 can't import dataset
5 participants
@ftconan @zhiltsov-max @bsekachev @yasakova-anastasia @SpecLad