Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for skeleton patch related with merge & delete, undo/redo #4875

Merged
merged 10 commits into from
Aug 30, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Aug 29, 2022

Motivation and context

Resolved #2157

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev changed the title [WIP] Some fixes for skeleton part related with merge & delete, undo/redo [WIP] Some fixes for skeleton patch related with merge & delete, undo/redo Aug 29, 2022
@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

❌ Some checks failed
📄 See logs here

@bsekachev
Copy link
Member Author

@klakhov Could you please look at this patch carefully and try it?

@bsekachev bsekachev changed the title [WIP] Some fixes for skeleton patch related with merge & delete, undo/redo Some fixes for skeleton patch related with merge & delete, undo/redo Aug 29, 2022
@bsekachev bsekachev added the bug Something isn't working label Aug 29, 2022
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge & delete works fine with this patch for me.

Btw what do you think about making merge selection for sceletons more noticable like its done with box tracks?
image
image

cvat-core/src/annotations-objects.ts Outdated Show resolved Hide resolved
cvat-core/src/annotations-collection.ts Outdated Show resolved Hide resolved
@bsekachev
Copy link
Member Author

Btw what do you think about making merge selection for sceletons more noticable like its done with box tracks?

@klakhov

I do not think it will work for skeletons, because they are not closed shapes.
We can only fill skeleton points to blue line like it is done for points shape.

@bsekachev
Copy link
Member Author

We can only fill skeleton points to blue line like it is done for points shape.

@klakhov

I did so.

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@bsekachev bsekachev merged commit 3db9c2d into develop Aug 30, 2022
@bsekachev bsekachev deleted the bs/minor_skeleton_fixes branch August 31, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not save annotations
2 participants