Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed redrawing a skeleton (Shift+N) #4906

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Fixed redrawing a skeleton (Shift+N) #4906

merged 5 commits into from
Sep 6, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Sep 6, 2022 •
edited
Loading

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev
Copy link
Member Author

@klakhov

Could you please review this patch ASAP?

@bsekachev bsekachev changed the title [WIP] Fixed redrawing a skeleton (Shift+N) Fixed redrawing a skeleton (Shift+N) Sep 6, 2022
@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@klakhov klakhov self-assigned this Sep 6, 2022
klakhov
klakhov reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redraw feature works nice for me 😀

tests/cypress/integration/skeletons_pipeline.js Outdated Show resolved Hide resolved
tests/cypress/integration/skeletons_pipeline.js Show resolved Hide resolved
tests/cypress/integration/skeletons_pipeline.js Outdated Show resolved Hide resolved
@bsekachev
Copy link
Member Author

/check

@bsekachev bsekachev closed this Sep 6, 2022
@bsekachev bsekachev reopened this Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022 •
edited
Loading

✔️ All checks completed successfully
📄 See logs here

@bsekachev bsekachev merged commit efd4363 into develop Sep 6, 2022
@bsekachev bsekachev deleted the bs/fixed_skeleton_redraw branch September 6, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klakhov klakhov klakhov approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

Assignees

@klakhov klakhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsekachev @klakhov