-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyAV dependency to 10.0.0 with ffmpeg5 support #5200
Conversation
/check |
❌ Some checks failed |
Please update ffmpeg version here https://github.com/opencv/cvat/blob/develop/Dockerfile#L29 as well |
Hi, thanks for the PR! I feel we might need to defer merging this PR till the next major release. There is a problem with video library versions that in different versions the results can be different (you can actually see it in the CI error report). |
I assume the ffmpeg version number here in the local cvat repo needs to also be changed before installing the requirements from |
UPD: changed the ffmpeg requirement in |
/check |
❌ Some checks failed |
If seems in the new version some frames are returned rotated 90 degrees. Could you please investigate? It may be related to the video rotation metainfo. |
Ok, I'll look into it. |
@inpv , thanks for the contribution. Unfortunately, the small change is huge. FFMPEG can be updated after huge testing. I will close the PR. |
Motivation and context
Since PyAV now has ffmpeg5 support, it could be safe to use it instead of 4.X and change the requirement in
/cvat/cvat/requirements/base.txt
.See this issue as well.
How has this been tested?
The dev env has been launched on Arch Linux, using packages from this PR.
All env components from
cvat/requirements/development.txt
install just fine withav
set to10.0.0
.Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.