Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyAV dependency to 10.0.0 with ffmpeg5 support #5200

Closed
wants to merge 8 commits into from

Conversation

inpv
Copy link
Contributor

@inpv inpv commented Oct 31, 2022

Motivation and context

Since PyAV now has ffmpeg5 support, it could be safe to use it instead of 4.X and change the requirement in /cvat/cvat/requirements/base.txt.
See this issue as well.

How has this been tested?

The dev env has been launched on Arch Linux, using packages from this PR.
All env components from cvat/requirements/development.txt install just fine with av set to 10.0.0.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@inpv inpv requested a review from nmanovic as a code owner October 31, 2022 01:57
@sizov-kirill
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

❌ Some checks failed
📄 See logs here

@azhavoro
Copy link
Contributor

Please update ffmpeg version here https://github.com/opencv/cvat/blob/develop/Dockerfile#L29 as well

@zhiltsov-max
Copy link
Contributor

Hi, thanks for the PR! I feel we might need to defer merging this PR till the next major release. There is a problem with video library versions that in different versions the results can be different (you can actually see it in the CI error report).

@inpv
Copy link
Contributor Author

inpv commented Nov 2, 2022

Please update ffmpeg version here https://github.com/opencv/cvat/blob/develop/Dockerfile#L29 as well

I assume the ffmpeg version number here in the local cvat repo needs to also be changed before installing the requirements from /cvat/cvat/requirements/ with pip (since it builds the container)?

@inpv
Copy link
Contributor Author

inpv commented Nov 2, 2022

UPD: changed the ffmpeg requirement in Dockerfile to 5.1.2 before pip reqs installation, containers launched just fine.

@inpv inpv requested a review from azhavoro as a code owner November 2, 2022 14:41
@zhiltsov-max
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

❌ Some checks failed
📄 See logs here

@zhiltsov-max
Copy link
Contributor

If seems in the new version some frames are returned rotated 90 degrees. Could you please investigate? It may be related to the video rotation metainfo.

@inpv
Copy link
Contributor Author

inpv commented Nov 3, 2022

If seems in the new version some frames are returned rotated 90 degrees. Could you please investigate? It may be related to the video rotation metainfo.

Ok, I'll look into it.

@nmanovic
Copy link
Contributor

@inpv , thanks for the contribution. Unfortunately, the small change is huge. FFMPEG can be updated after huge testing. I will close the PR.

@nmanovic nmanovic closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants