Fix typing of credentials parameter of make_client in the Python SDK #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type of the credentials parameter was Optional[Tuple[int, int]], but it should be Optional[Tuple[str, str]].
zhiltsov-max
approved these changes
Jan 20, 2023
nmanovic
approved these changes
Jan 21, 2023
sizov-kirill
pushed a commit
that referenced
this pull request
Jan 30, 2023
…5609) ### Motivation and context This is a very simple pull request. The type of the credentials parameter of `make_client` is currently `Optional[Tuple[int, int]]`, but it should be `Optional[Tuple[str, str]]` as used by `Client#login`. This PR makes that change. ### How has this been tested? The typing does not affect the functionality of the code (just the warnings I get in an IDE).
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
…vat-ai#5609) ### Motivation and context This is a very simple pull request. The type of the credentials parameter of `make_client` is currently `Optional[Tuple[int, int]]`, but it should be `Optional[Tuple[str, str]]` as used by `Client#login`. This PR makes that change. ### How has this been tested? The typing does not affect the functionality of the code (just the warnings I get in an IDE).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This is a very simple pull request. The type of the credentials parameter of
make_clientis currentlyOptional[Tuple[int, int]], but it should beOptional[Tuple[str, str]]as used byClient#login. This PR makes that change.How has this been tested?
The typing does not affect the functionality of the code (just the warnings I get in an IDE).
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.