Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] Add tooltip to long project card name #7550

Merged

Conversation

syedbarimanjan
Copy link
Contributor

@syedbarimanjan syedbarimanjan commented Mar 4, 2024

Motivation and context

Fixes #6874 I added a tooltip component to the name of the project and task card. When someone hovers over the name it will display the name in a tooltip above it.
Screenshot from 2024-03-04 20-24-42
Screenshot from 2024-03-05 00-12-35

How has this been tested?

On all ui breakpoints.

Checklist

  • I submit my changes into the develop branch
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@syedbarimanjan syedbarimanjan changed the title Add tooltip to long project card name [GSoC2024] Add tooltip to long project card name Mar 6, 2024
@bsekachev
Copy link
Member

Also it would be great to have the same approach we should use now for Cloud Storages and Models page.
Now the names are not visible
image
image

@syedbarimanjan
Copy link
Contributor Author

syedbarimanjan commented Mar 13, 2024

Also it would be great to have the same approach we should use now for Cloud Storages and Models page. Now the names are not visible image image

I have implemented the changes.
Screenshot from 2024-03-13 15-42-22
Screenshot from 2024-03-13 15-42-10

@bsekachev
Copy link
Member

May you please add changelog fragment?

scriv create --edit, and add description with PR link. Description is something line:

Added:
    - Tooltips for long resources names (projects, tasks, cloud storages, and models)

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #7550 (7370214) into develop (ae7999b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7550      +/-   ##
===========================================
- Coverage    83.46%   83.44%   -0.03%     
===========================================
  Files          373      373              
  Lines        39739    39739              
  Branches      3741     3741              
===========================================
- Hits         33168    33160       -8     
- Misses        6571     6579       +8     
Components Coverage Δ
cvat-ui 79.23% <ø> (-0.04%) ⬇️
cvat-server 87.32% <ø> (-0.01%) ⬇️

@bsekachev
Copy link
Member

ESLint found one error in current changes:

/home/runner/work/cvat/cvat/cvat-ui/src/components/tasks-page/task-item.tsx
Error:   10:8  error  'Paragraph' is defined but never used  @typescript-eslint/no-unused-vars

@bsekachev
Copy link
Member

Thank you for active contributing to the project

@bsekachev bsekachev merged commit f22322f into cvat-ai:develop Mar 14, 2024
33 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create pop up containing entire task name when hovering over a task in both project and task list CVAT UI
2 participants