Fixed duplicated notifications for automatic annotation #7595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7595 +/- ##
===========================================
- Coverage 83.41% 83.39% -0.03%
===========================================
Files 373 373
Lines 39722 39728 +6
Branches 3741 3743 +2
===========================================
- Hits 33136 33131 -5
- Misses 6586 6597 +11
|
klakhov
force-pushed
the
kl/fix-auto-annotation-notifications
branch
from
97bcc63
to
ecf8606
Compare
bsekachev
reviewed
Mar 26, 2024
| return { | ||
| ...state, | ||
| inferences: Object.fromEntries( | ||
| Object.entries(inferences).filter(([key]): boolean => +key !== action.payload.taskID), | ||
| ), | ||
| requestedInferenceIDs: { ...requestedInferenceIDs }, |
There was a problem hiding this comment.
- Let's refactor a little bit with
lodash.omitfor bothinferencesandrequestedInferenceIDs - The same for
CANCEL_INFERENCE_SUCCESS
bsekachev
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
If we go over different task pages while automatic annotation is in progress, on its successful finish we get duplicated notifications.That happens because each time we go to new page in task list or open a task, new listener to request status is created.
How has this been tested?
Manual testing
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.