Remove several fields from DataSerializer
#7663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
clean-data-serializer
branch
from
88ab669
to
846582f
Compare
`original_chunk_type` and `compressed_chunk_type` have no effect, because the task creation code overwrites these values based on `use_zip_chunks`. With `size`, the code relies on the default of zero, and attempting to overriding it will just lead to an incorrect value being saved to the database.
SpecLad
force-pushed
the
clean-data-serializer
branch
from
846582f
to
06d2c68
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7663 +/- ##
===========================================
- Coverage 83.46% 83.40% -0.06%
===========================================
Files 373 373
Lines 39716 39722 +6
Branches 3741 3741
===========================================
- Hits 33150 33132 -18
- Misses 6566 6590 +24
|
azhavoro
approved these changes
Apr 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
original_chunk_typeandcompressed_chunk_typehave no effect, because the task creation code overwrites these values based onuse_zip_chunks. Withsize, the code relies on the default of zero, and attempting to overriding it will just lead to an incorrect value being saved to the database.How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.