Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] Added feature to show tags corresponding to GT job and manual job in a separate row #7774

Merged
merged 22 commits into from
May 7, 2024

Conversation

Viditagarwal7479
Copy link
Contributor

@Viditagarwal7479 Viditagarwal7479 commented Apr 15, 2024

Fixes #7773 and #7749

Added feature to show tags corresponding to GT job and manual job in a separate row. Along with the tags of the GT job have a mark of '(GT)' in them.

How has this been tested?

When we want to see both manual annotations and GT annotations:
image loading...

When we only want to see the annotations for the manual annotations job:
image loading...

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
    - [ ] I have updated the documentation accordingly
    - [ ] I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
    - [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Introduced display tags for Ground Truth (GT) and manual jobs in a separate row, with GT tags marked for easy identification.
    • Enhanced tag highlighting in the annotation interface to better indicate conflicts.
  • Style

    • Implemented new styles for frame tags to improve visual distinction when highlighted.

@Viditagarwal7479 Viditagarwal7479 changed the title [GSOC'24] Added feature to show tags corresponding to GT job and manual job in a separate row [GSoC2024] Added feature to show tags corresponding to GT job and manual job in a separate row Apr 15, 2024
@bsekachev bsekachev requested review from klakhov and removed request for nmanovic April 16, 2024 05:31
@zhiltsov-max
Copy link
Contributor

Hi, what do you think if we swap the order or these 2 tag lists? This way, when we enable and disable the GT display, the current job tags will stay in place, and GT tags will only be shown or hidden in a line below, i.e. the current job tags won't "jump".

@Viditagarwal7479
Copy link
Contributor Author

Hi, what do you think if we swap the order or these 2 tag lists? This way, when we enable and disable the GT display, the current job tags will stay in place, and GT tags will only be shown or hidden in a line below, i.e. the current job tags won't "jump".

Hello @zhiltsov-max , thanks for suggesting this, it would definitely look more elegant to the user.

@Viditagarwal7479
Copy link
Contributor Author

A gentle reminder of this PR 😅

Copy link
Contributor

coderabbitai bot commented Apr 26, 2024

Walkthrough

This update enhances CVAT's UI by differentiating tags related to manual and GT (Ground Truth) jobs in the annotation workspace. It introduces a new method for updating conflicts in highlighted tags and adds styling for better visibility and distinction of these tags.

Changes

File Path Summary of Changes
changelog.d/..._ui_tag_annotations.md Introduced feature for displaying GT and manual job tags separately, with GT tags marked for identification.
cvat-ui/.../canvas-wrapper.tsx Updated highlighting logic for tag conflicts and added method to handle these updates.
cvat-ui/.../frame-tags.tsx & styles.scss Enhanced tag rendering with conflict highlighting and added styles for frame tags.

Assessment against linked issues

Objective Addressed Explanation
Adding distinguishing element between tags for manual and GT job (#7773)

🐇✨
In the land of code and canvas,
A rabbit hopped through, quite zealous.
With tags now clear, distinct, and bright,
GT and manual, split by sight.
🌟🐾


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@klakhov
Copy link
Contributor

klakhov commented May 3, 2024

@zhiltsov-max
I belive the UI part is ready, could you look on it? Is it what you expected?

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks nice to me.

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@klakhov klakhov merged commit 7f1ae38 into cvat-ai:develop May 7, 2024
32 checks passed
@Viditagarwal7479
Copy link
Contributor Author

Yayy!

@Viditagarwal7479 Viditagarwal7479 deleted the ui-tag-annotations branch May 9, 2024 02:46
@cvat-bot cvat-bot bot mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding distinguishing element between tags corresponding to manual job and GT job
4 participants