-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC2024] Added feature to show tags corresponding to GT job and manual job in a separate row #7774
Conversation
…k of (GT) in label name
Hi, what do you think if we swap the order or these 2 tag lists? This way, when we enable and disable the GT display, the current job tags will stay in place, and GT tags will only be shown or hidden in a line below, i.e. the current job tags won't "jump". |
Hello @zhiltsov-max , thanks for suggesting this, it would definitely look more elegant to the user. |
A gentle reminder of this PR 😅 |
cvat-ui/src/components/annotation-page/tag-annotation-workspace/frame-tags.tsx
Outdated
Show resolved
Hide resolved
…Conflict state is updated with props value
…ight annotation of type Tag
cvat-ui/src/components/annotation-page/canvas/views/canvas2d/canvas-wrapper.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/canvas/views/canvas2d/canvas-wrapper.tsx
Outdated
Show resolved
Hide resolved
WalkthroughThis update enhances CVAT's UI by differentiating tags related to manual and GT (Ground Truth) jobs in the annotation workspace. It introduces a new method for updating conflicts in highlighted tags and adds styling for better visibility and distinction of these tags. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
changelog.d/20240416_022857_vidit.agarwal.eee20_ui_tag_annotations.md
Outdated
Show resolved
Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
changelog.d/20240416_022857_vidit.agarwal.eee20_ui_tag_annotations.md
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/canvas/views/canvas2d/canvas-wrapper.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
cvat-ui/src/components/annotation-page/canvas/views/canvas2d/canvas-wrapper.tsx
Show resolved
Hide resolved
@zhiltsov-max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, looks nice to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Yayy! |
Fixes #7773 and #7749
Added feature to show tags corresponding to GT job and manual job in a separate row. Along with the tags of the GT job have a mark of '(GT)' in them.
How has this been tested?
When we want to see both manual annotations and GT annotations:
When we only want to see the annotations for the manual annotations job:
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Style