Update helm #7894
Update helm #7894
Conversation
Removed passing of DJANGO_MODWSGI_EXTRA_ARGS env cariable to server pod Do not set database host and port env variables if they are empty
|
Warning Rate Limit Exceeded@azhavoro has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 27 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update to the Helm chart primarily focuses on enhancing the configuration of backend pods by introducing the ability to specify a ServiceAccount. Additionally, it updates the version number to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (12)
- helm-chart/Chart.yaml (1 hunks)
- helm-chart/templates/_helpers.tpl (2 hunks)
- helm-chart/templates/cvat_backend/initializer/job.yml (1 hunks)
- helm-chart/templates/cvat_backend/server/deployment.yml (2 hunks)
- helm-chart/templates/cvat_backend/utils/deployment.yml (1 hunks)
- helm-chart/templates/cvat_backend/worker_analyticsreports/deployment.yml (1 hunks)
- helm-chart/templates/cvat_backend/worker_annotation/deployment.yml (1 hunks)
- helm-chart/templates/cvat_backend/worker_export/deployment.yml (1 hunks)
- helm-chart/templates/cvat_backend/worker_import/deployment.yml (1 hunks)
- helm-chart/templates/cvat_backend/worker_qualityreports/deployment.yml (1 hunks)
- helm-chart/templates/cvat_backend/worker_webhooks/deployment.yml (1 hunks)
- helm-chart/values.yaml (3 hunks)
Files skipped from review due to trivial changes (1)
- helm-chart/Chart.yaml
Additional comments not posted (13)
helm-chart/templates/cvat_backend/initializer/job.yml (1)
40-40: Addition ofserviceAccountNamefield looks good and aligns with the objective to specify a ServiceAccount for backend pods.helm-chart/templates/cvat_backend/worker_webhooks/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the objective to specify a ServiceAccount for backend pods.helm-chart/templates/cvat_backend/worker_qualityreports/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the objective to specify a ServiceAccount for backend pods.helm-chart/templates/cvat_backend/worker_analyticsreports/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the objective to specify a ServiceAccount for backend pods.helm-chart/templates/_helpers.tpl (2)
54-57: Renaming the service account name definition tocvat.backend.serviceAccountNameis clear and aligns with the updated structure.
97-104: The addition of conditional blocks forCVAT_POSTGRES_HOSTandCVAT_POSTGRES_PORTenvironment variables ensures that they are only set if the external PostgreSQL host and port are provided. This is a good practice to avoid setting empty environment variables.helm-chart/templates/cvat_backend/utils/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the objective to specify a ServiceAccount for backend pods.helm-chart/templates/cvat_backend/server/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the PR objectives.helm-chart/templates/cvat_backend/worker_export/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the PR objectives.helm-chart/templates/cvat_backend/worker_import/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the PR objectives.helm-chart/templates/cvat_backend/worker_annotation/deployment.yml (1)
48-48: Addition ofserviceAccountNamefield looks good and aligns with the PR objectives.helm-chart/values.yaml (2)
20-24: Addition ofserviceAccountsection looks good and aligns with the PR objectives.
282-285: Modification to allow empty values forhostandportin theexternalsection underpostgresqllooks good and aligns with the PR objectives.
| ### Added <!-- pick one --> | ||
|
|
||
| - [Helm] Ability to specify ServiceAccount for backend pods | ||
| (<https://github.com/cvat-ai/cvat/pull/7894>) |
There was a problem hiding this comment.
Include all significant changes in the changelog entry.
The current changelog entry is missing information about the removal of the DJANGO_MODWSGI_EXTRA_ARGS environment variable and the conditional setting of database host and port environment variables. Consider updating the entry to reflect these changes for completeness.
### Added <!-- pick one -->
- [Helm] Ability to specify ServiceAccount for backend pods
(<https://github.com/cvat-ai/cvat/pull/7894>)
- [Helm] Removed `DJANGO_MODWSGI_EXTRA_ARGS` environment variable from server pod
- [Helm] Conditional setting of database host and port environment variablesCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ### Added <!-- pick one --> | |
| - [Helm] Ability to specify ServiceAccount for backend pods | |
| (<https://github.com/cvat-ai/cvat/pull/7894>) | |
| ### Added <!-- pick one --> | |
| - [Helm] Ability to specify ServiceAccount for backend pods | |
| (<https://github.com/cvat-ai/cvat/pull/7894>) | |
| - [Helm] Removed `DJANGO_MODWSGI_EXTRA_ARGS` environment variable from server pod | |
| - [Helm] Conditional setting of database host and port environment variables |
Co-authored-by: Roman Donchenko <roman@cvat.ai>
Co-authored-by: Roman Donchenko <roman@cvat.ai>
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- helm-chart/templates/_helpers.tpl (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- helm-chart/templates/_helpers.tpl
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- helm-chart/values.yaml (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- helm-chart/values.yaml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7894 +/- ##
===========================================
- Coverage 83.33% 83.33% -0.01%
===========================================
Files 380 380
Lines 40022 40022
Branches 3766 3766
===========================================
- Hits 33353 33352 -1
- Misses 6669 6670 +1
|
Added ability to specify ServiceAccount for backend pods
Removed passing of DJANGO_MODWSGI_EXTRA_ARGS env variable to server pod
Do not set database host and port env variables if they are empty
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Improvements
Removals
DJANGO_MODWSGI_EXTRA_ARGSenvironment variable setting.Documentation