Fixed exception: Cannot read properties of undefined (reading 'onBloc…

[bsekachev]

…kUpdated')

Motivation and context

Does not affect user actually, but creates annoying exceptions in analytics

To reproduce:

1. Create a mask somehow without manual drawing (AI tools, converters, or already exist when open a job)
2. Copy past the mask

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
• I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

• Bug Fixes
  • Improved performance and accuracy when updating drawn objects in the mask handler.

[coderabbitai]

Warning

Rate Limit Exceeded

@bsekachev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 48 minutes and 43 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between fd91638 and c1ce186.

Walkthrough

The update simplifies the logic in MasksHandlerImpl of masksHandler.ts, ensuring drawnObjects is managed more efficiently by directly assigning a single-element array for the image object.

Changes

File	Change Summary
cvat-canvas/src/typescript/masksHandler.ts	Updated logic in MasksHandlerImpl to assign drawnObjects as a single-element array instead of pushing a new image object.
changelog.d/20240520_102857_boris_fixed_exception_1.md	Fixed a bug related to 'onBlockUpdated' preventing exceptions by addressing properties of undefined.

Poem

Amongst the code's intricate dance,
A single image, a new stance.
No more pushing, just a single array,
Bugs fixed, brightening the day.
With grace and unity in the code's delight,
Errors vanish, in the canvas's light.
🎨✨🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1a86ccd and 728a7de.

Files selected for processing (1)

• cvat-canvas/src/typescript/masksHandler.ts (1 hunks)

Additional comments not posted (1)

cvat-canvas/src/typescript/masksHandler.ts (1)

575-575: Verify interactions with drawnObjects in other methods.

Ensure that methods like releaseDraw, releaseEdit, and any other method that interacts with drawnObjects are compatible with the new assignment logic.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 728a7de and fd91638.

Files selected for processing (1)

• changelog.d/20240520_102857_boris_fixed_exception_1.md (1 hunks)

Additional comments not posted (1)

changelog.d/20240520_102857_boris_fixed_exception_1.md (1)

1-4: Changelog entry is clear and properly formatted.