The property outside not propagated correctly on skeleton elements

[bsekachev]

Motivation and context

The issue reported by customer

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
• I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

• Bug Fixes
  • Resolved an issue where the "outside" property was not being propagated correctly on skeleton elements.

[coderabbitai]

Walkthrough

This update ensures that the "outside" property is correctly propagated in the skeleton elements of the cvat-core library. The propagateShapes function in object-utils.ts was adjusted to include the "outside" property, resolving a bug where this attribute was not being handled properly, thus improving the robustness and consistency of shape property management.

Changes

File	Change Summary
changelog.d/20240702_085300_boris.md	Added a new changelog entry summarizing the fix for the propagation of the "outside" property in skeleton elements.
cvat-core/src/object-utils.ts	Updated the propagateShapes function to correctly propagate the "outside" property from the shape parameter.

Poem

In code’s vast field where bugs would roam,
A rabbit hopped through lines unknown,
Fixed the "outside" in a shape's fine nest,
Now all properties can rest.
No more stray bits, no more plight,
Skeletons, rejoice—a future bright!
🐇✨debugs dance tonight!

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4ccc29d and 65880c4.

Files selected for processing (2)

• changelog.d/20240702_085300_boris.md (1 hunks)
• cvat-core/src/object-utils.ts (2 hunks)

Additional comments not posted (3)

changelog.d/20240702_085300_boris.md (1)

1-4: Changelog entry looks good.

The changelog entry accurately describes the fixed issue and includes a link to the pull request.

cvat-core/src/object-utils.ts (2)

371-371: LGTM! Ensure all function calls match the new logic.

The change correctly ensures that the outside property is propagated for ObjectState instances.

---

396-396: LGTM! Ensure all function calls match the new logic.

The change correctly ensures that the outside property is propagated for SerializedShape instances.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (6d49b89) to head (65880c4).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8105      +/-   ##
===========================================
+ Coverage    83.63%   83.66%   +0.02%     
===========================================
  Files          383      383              
  Lines        40503    40502       -1     
  Branches      3831     3830       -1     
===========================================
+ Hits         33876    33887      +11     
+ Misses        6627     6615      -12     

Components	Coverage Δ
cvat-ui	79.73% <ø> (+0.05%)	⬆️
cvat-server	87.26% <ø> (+<0.01%)	⬆️