build-config/project: updating the name field / making step Optional & Computed
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a Build Configuration based on a Template, once the build has first been created - Terraform shows a diff because the Build Steps are missing from the configuration but returned from the API. As such this commit makes this block `Optional` & `Computed` so that this diff can be omitted if a user hasn't specified any `step` blocks to override this in the config (e.g. wants to /only/ use steps from the template).
Merged
cvbarros
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
👋 @tombuildsstuff this is gtg, except for a minor comment - client 1.2.0 has been pushed, so if you could kindly rebase on master for CI tests, that would be 💯 . Thanks!
| Config: testAccTeamcityProjectFullUpdated, | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckTeamcityProjectExists(resName, &p), | ||
| resource.TestCheckResourceAttr(resName, "description", "updated project"), |
There was a problem hiding this comment.
Would this attr check be name or description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes:
stepblock ComputedWhen creating a Build Configuration based on a Template, once the build has first been created - Terraform shows a diff because the Build Steps are missing from the configuration but returned from the API.
As such this commit makes this block
Optional&Computedso that this diff can be omitted if a user hasn't specified anystepblocks to override this in the config (e.g. wants to /only/ use steps from the template).Dependent on cvbarros/go-teamcity#81
Dependent on cvbarros/go-teamcity#82