Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable DownloadMaxWorkers (#890) #998

Merged
merged 4 commits into from
Sep 2, 2023
Merged

Configurable DownloadMaxWorkers (#890) #998

merged 4 commits into from
Sep 2, 2023

Conversation

oh2fih
Copy link
Contributor

@oh2fih oh2fih commented Sep 2, 2023

The issue #890 was closed, but the bug was reproduced by three users (@nikalexo, @brainsht & @frosteyes).

This PR makes the max_workers for the download actions in the lib/DownloadHandler.py configurable.

The new section [Download] has a new configuration parameter MaxWorkers defaulting to 10 as suggested by @frosteyes.

@P-T-I
Copy link
Member

P-T-I commented Sep 2, 2023

TY

@P-T-I P-T-I merged commit b01b57c into cve-search:master Sep 2, 2023
5 of 6 checks passed
@oh2fih
Copy link
Contributor Author

oh2fih commented Sep 2, 2023

Wasn't yet able to fully fix the web_tests pipeline, but got a bit closer maybe.

Solves the issue #890 anyway, and doesn't affect the web component – the pipeline has been broken for some time.

@P-T-I
Copy link
Member

P-T-I commented Sep 2, 2023

True...

@frosteyes
Copy link

I have just tested it with https://github.com/cve-search/CVE-Search-Docker and it works perfect to my needs.
Thanks @oh2fih

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants