Bump windows cookbook dependency #111
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 136 136
=====================================
Hits 136 136Continue to review full report at Codecov.
|
metadata.rb
Outdated
| @@ -9,7 +9,7 @@ | |||
| issues_url 'https://github.com/cvent/octopus-deploy-cookbook/issues' | |||
| version '0.12.0' | |||
|
|
|||
| depends 'windows', '>= 1.38.0' | |||
| depends 'windows', '>= 3.0.5' | |||
There was a problem hiding this comment.
I actually think we do not need the cookbook anymore. The main reason for having it was simply for backwards compatibility issues.
There was a problem hiding this comment.
Ahh forgot about the tools resource which does require it. I would prefer to just not specify a version here TBH and make it so its picked outside of this cookbook.
There was a problem hiding this comment.
Sever and tentacle don't, but it looks like tools still uses the windows_zipfile resource which I believe does require the windows cookbook.
https://github.com/cvent/octopus-deploy-cookbook/blob/master/resources/tools.rb#L44-L48
There was a problem hiding this comment.
Usually I believe in pinning cookbook versions, however in this case I think you are right. The likelyhood users will run into dependency hell if they have other cookbooks that depend on the windows cookbook outweighs the risk that the windows_zipfile resource api will break.
There was a problem hiding this comment.
I am not sure if the version >= 1.38.0 was needed or not, One thing you could do is add a dependency on windows >= 3.0.5 in the berksfile so that in testing it would use that version.
|
I've added windows cookbook dependency to berkshelf, and removed the version pin from the metadata file. |
spuder
force-pushed
the
29-windows_package
branch
2 times, most recently
from
836f3dd
to
0c278b6
Compare
Berksfile
Outdated
| @@ -3,6 +3,8 @@ source 'https://supermarket.chef.io/' | |||
|
|
|||
| metadata | |||
|
|
|||
| cookbook 'windows', '~> 3.0.5' | |||
There was a problem hiding this comment.
Can we put this in the test group?
spuder
force-pushed
the
29-windows_package
branch
from
0c278b6
to
19f18dd
Compare
No longer required if using chef >=12.4
spuder
force-pushed
the
29-windows_package
branch
from
19f18dd
to
32abe47
Compare
Resolves issue #29
Bump windows cookbook version now that
windows_packageis part of chef 12.Windows cookbook 3.0.x no longer includes windows_package resource.
I intentionally didn't upgrade to 3.1.x since that version of the windows cookbook requires chef 12.7.x
The
windows_zipfilehas no breaking changes so there should be no change in behavior.https://github.com/chef-cookbooks/windows/blob/master/CHANGELOG.md