Loosen up dependency version locking #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentm5
requested changes
Oct 4, 2016
| @@ -8,8 +8,8 @@ | |||
| issues_url 'https://github.com/cvent/octopus-deploy-cookbook/issues' | |||
| version '0.6.5' | |||
|
|
|||
| depends 'windows', '~> 1.38' | |||
| depends 'windows_firewall', '~> 3.0.2' | |||
| depends 'windows', '>= 1.38.0' | |||
There was a problem hiding this comment.
I am fine with removing the constraint on this entirely TBH. The windows cookbook is simply used to support legacy clients.
| depends 'windows', '~> 1.38' | ||
| depends 'windows_firewall', '~> 3.0.2' | ||
| depends 'windows', '>= 1.38.0' | ||
| depends 'windows_firewall', '>= 3.0.2' |
There was a problem hiding this comment.
I think this should be '~> 3.0' This has a dependency on 3.0 at the moment. If that API changes then I want to update that explicitly
There was a problem hiding this comment.
fair enough on the windows_firewall cookbook.
brentm5
changed the title
brentm5
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the cookbook pinning from pessimistic pinning.