fix apache#4406

cvictory · Jun 27, 2019 · 98c3906 · 98c3906
1 parent acae8d9
commit 98c3906
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/dubbo-all/pom.xml b/dubbo-all/pom.xml
@@ -764,6 +764,10 @@
                                     <resource>META-INF/dubbo/internal/org.apache.dubbo.metadata.store.MetadataReportFactory
                                     </resource>
                                 </transformer>
+                                <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+                                    <resource>META-INF/dubbo/internal/org.apache.dubbo.metadata.definition.builder.TypeBuilder
+                                    </resource>
+                                </transformer>
                             </transformers>
                             <filters>
                                 <filter>

diff --git a/...-definition/src/main/java/org/apache/dubbo/metadata/definition/TypeDefinitionBuilder.java b/...-definition/src/main/java/org/apache/dubbo/metadata/definition/TypeDefinitionBuilder.java
@@ -17,6 +17,8 @@
 package org.apache.dubbo.metadata.definition;
 
 import org.apache.dubbo.common.extension.ExtensionLoader;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
 import org.apache.dubbo.metadata.definition.builder.DefaultTypeBuilder;
 import org.apache.dubbo.metadata.definition.builder.TypeBuilder;
 import org.apache.dubbo.metadata.definition.model.TypeDefinition;
@@ -31,6 +33,7 @@
  * 2015/1/27.
  */
 public class TypeDefinitionBuilder {
+    private static final Logger logger = LoggerFactory.getLogger(TypeDefinitionBuilder.class);
     private static final List<TypeBuilder> BUILDERS;
 
     static {
@@ -57,8 +60,13 @@ public static TypeDefinition build(Type type, Class<?> clazz, Map<Class<?>, Type
 
     private static TypeBuilder getGenericTypeBuilder(Type type, Class<?> clazz) {
         for (TypeBuilder builder : BUILDERS) {
-            if (builder.accept(type, clazz)) {
-                return builder;
+            try {
+                if (builder.accept(type, clazz)) {
+                    return builder;
+                }
+            } catch (NoClassDefFoundError cnfe) {
+                //ignore
+                logger.warn("Throw classNotFound (" + cnfe.getMessage() + ") in " + builder.getClass());
             }
         }
         return null;