Slug command #208
Closed
Slug command #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll update the README after this to point merge requests against master ... thanks! I see that the Laravel 5.1 way of declaring command arguments and options is different, but I assume the "old" way works still. I may eventually need to branch out a 5.x and 5.1 version, I guess ... but don't worry about that for now. However, can you please write a test for this as well? Happy to merge after that! |
|
Sorry I never merged this earlier. It's a good suggestion! Any chance I can get you to resubmit the merge against the new 4.0 branch? And add a test, please! |
|
I tried to. But I had some problems installing the framework. I don't do PHP anymore. I could write something up without running it, but obviously I cannot guarantee it will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README says to create a pull request against the development branch, but no such branch exist. So I picked master.