Some little corrections

[biesseck]

Here are corrections to some issues related to ".lock" folder, multithread execution, invalid name of folders and feature extraction using "opencvDetector"

[kmyi]

Hello,

Thanks for the PR.
However, it just made me realize that some of the files were again
ommited from the git repository due to .gitignore files.
They are now fixed, and you should be able to run the opencv related
dependencies.
Also, .lock folder is included by default now, as this one is not for
multithreading but actually multi-processing on clusters.

Sorry that we are basically abusing you as our beta tester :-(
Once I get back from my holidays, I will re-run a full testing again on
a completely new machine, just to be sure.

Thanks,
Kwang

On 07/22/2016 07:15 PM, Bernardo Biesseck wrote:

Here are corrections to some issues related to ".lock" folder,
multithread execution, invalid name of folders and feature extraction
using "opencvDetector"

---

    You can view, comment on, or merge this pull request online at:

#1

    Commit Summary

• computeDescriptors.m - check and create '.lock' folder

• run_evaluate() and computeDescriptors(): create variable
  'parameters.useMultithread' to allow running without multithread

• run_evaluate() and evaluateDescriptors(): create variable
  'parameters.pathDatasets' to allow storing datasets out of
  'benchmark-orientation/data' folder

• getKeypoints_SIFT(): 1) use system() function to run
  'opencvDetector' program; 2) add python script 'opencvDetector.py'
  to run 'opencvDetector' program

• getOrientations_GHHPooling() - line 107: corrects folder name
  'learn-orientation-release' to 'learn-orientation'

• getKeypoints_SIFT(): setting LD_LIBRARY_PATH variable before
  running 'system()' to run 'opencvDetector'

  File Changes
  

• A matlab/external/methods/opencvDetector.py
  https://github.com/cvlab-epfl/benchmark-orientation/pull/1/files#diff-0
  (44)

• M matlab/src/KeypointDetectors/_SIFT/getKeypoints_SIFT.m
  https://github.com/cvlab-epfl/benchmark-orientation/pull/1/files#diff-1
  (24)

• M
  matlab/src/KeypointOrientations/GHHPooling/getOrientations_GHHPooling.m
  https://github.com/cvlab-epfl/benchmark-orientation/pull/1/files#diff-2
  (2)

• M matlab/src/Utils/computeDescriptors.m
  https://github.com/cvlab-epfl/benchmark-orientation/pull/1/files#diff-3
  (31)

• M matlab/src/Utils/evaluateDescriptors.m
  https://github.com/cvlab-epfl/benchmark-orientation/pull/1/files#diff-4
  (3)

• M matlab/src/run_evaluate.m
  https://github.com/cvlab-epfl/benchmark-orientation/pull/1/files#diff-5
  (21)

  Patch Links:
  

• https://github.com/cvlab-epfl/benchmark-orientation/pull/1.patch

• https://github.com/cvlab-epfl/benchmark-orientation/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG0RFUV19n0CkGm2e2jZ7SdYLlcbiIJEks5qYPqvgaJpZM4JS9Mi.

---

Kwang Moo Yi, Ph.D.
PostDoc Researcher in CVLAB

École Polytechnique Fédérale de Lausanne
EPFL CVLAB
BC 300 (Bâtiment BC)
Station 14
CH-1015 Lausanne,
SWITZERLAND

Email: kwang.yi@epfl.ch
Phone: +41 78 808 47 95

---

[zhoululu0304]

Dear master,
I get your github code recently, but i don't understand some place. Fistly, I don't know if the <keypoint_file_name> <config_file_name> <output_file_name> made buy myself. Secondly , if these three files should made by myself, how can i write?
Sincerely.