Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUCC] support wildcard in image specification #2490

Merged
merged 23 commits into from Feb 20, 2020
Merged

[DUCC] support wildcard in image specification #2490

merged 23 commits into from Feb 20, 2020

Conversation

siscia
Copy link
Contributor

@siscia siscia commented Feb 10, 2020 •
edited

Adding tag wildcards to DUCC

This PR allow to specify images in the whishlist in the format of:

https://registry.hub.docker.com/library/redis:*

This will include all the images library/redis regardless of the tag.

@siscia
add flag to opt-out of docker conversion
dd5bb05
@siscia
pump go.mod
9f6a5d6
@siscia
redirect all the temporary directory using a command line flag
ee2850c
@siscia
read temporary-dir from ENV DUCC_TMP_DIR if not set by command line args
ca886a9
@siscia
small fixes for custom directories
ebcd20e
@siscia
Merge branch 'devel' of github.com:cvmfs/cvmfs into devel
f6d236f
@siscia
check singularity version
7e33634
@siscia
preparatory work for supporting start wildcard, add field to struct, …
bf3d101 
…refactor code to allow loops over images and add test for detection of star wildcard
@siscia
add logic to retrieve the tags of an image
5ef6a98
@siscia
add test for tags retrieving
d887ea0
@siscia
add tags expansions also to singularity
985747c
@siscia
explain problems with pagination
950ea77
@siscia
avoid re-ingest singularity if directory is already ingested
a1a0b89
@siscia
smart reuse of singularity images already in the repo
6fe3a48
@siscia
add test for ingestion of tag with star wildcard
a6619b2
@siscia siscia changed the title [WIP] DUCC StarWildcard DUCC StarWildcard Feb 12, 2020
@siscia
Copy link
Contributor Author

siscia commented Feb 12, 2020 •
edited

CVM-1715 and CVM-1829

@siscia
Copy link
Contributor Author

siscia commented Feb 13, 2020

@jblomer I would like your input, especially on the testing part.

@jblomer jblomer changed the title DUCC StarWildcard [DUCC] support wildcard in image specification Feb 13, 2020
jblomer
jblomer reviewed Feb 13, 2020
View reviewed changes
test/src/403-ducc-star/main Show resolved Hide resolved
ducc/lib/parse_test.go Outdated Show resolved Hide resolved
ducc/lib/image.go Outdated Show resolved Hide resolved
ducc/lib/conversion.go Outdated Show resolved Hide resolved
ducc/lib/conversion.go Outdated Show resolved Hide resolved
siscia
siscia commented Feb 14, 2020
View reviewed changes
ducc/lib/conversion.go Outdated Show resolved Hide resolved
@siscia
Copy link
Contributor Author

siscia commented Feb 17, 2020

@cernvm-bot cpplint

@cernvm-bot
Copy link
Collaborator

linter finished:
no errors

@siscia
Copy link
Contributor Author

siscia commented Feb 17, 2020

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building CVMFS for cloudtesting

@cernvm-bot
Copy link
Collaborator

building finished: SUCCESS https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/2017/

@cernvm-bot
Copy link
Collaborator

running cloudtests

@cernvm-bot
Copy link
Collaborator

cloudtesting finished: FAILURE https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsCloudTesting/530/

@siscia
Copy link
Contributor Author

siscia commented Feb 19, 2020

I believe this is stable enough to be merged!
I will merge it tomorrow if nobody objects :)

@siscia siscia merged commit fa54c0c into cvmfs:devel Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblomer jblomer jblomer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siscia @cernvm-bot @jblomer