Do not include an explicit default port number within S3 upload URI #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The S3 uploader will currently always include an explicit port number within URIs (e.g. "http://mybucket.s3.us-east-1.amazonaws.com:80") even when using the default HTTP port 80. This is not incorrect, but unfortunately triggers a bug within libcurl (see curl/curl#6769) that causes it to construct requests that will be rejected if they happen to pass through HAProxy. Work around this libcurl bug by omitting an explicit port number from the constructed URI when the default port is used. Signed-off-by: Michael Brown <mbrown@fensystems.co.uk>
|
Can one of the admins verify this patch? |
|
@cernvm-bot cloudtest |
|
@cernvm-bot cpplint |
|
@cernvm-bot unittest |
|
building for cloudtests finished: SUCCESS |
|
cloudtests finished: SUCCESS |
jblomer
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S3 uploader will currently always include an explicit port number
within URIs (e.g. "http://mybucket.s3.us-east-1.amazonaws.com:80")
even when using the default HTTP port 80.
This is not incorrect, but unfortunately triggers a bug within libcurl
(see curl/curl#6769) that causes it to
construct requests that will be rejected if they happen to pass
through HAProxy.
Work around this libcurl bug by omitting an explicit port number from
the constructed URI when the default port is used.
Signed-off-by: Michael Brown mbrown@fensystems.co.uk