Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error "'time' was not declared in this scope" #3046

Merged
merged 1 commit into from Sep 4, 2022
Merged

Fix compile error "'time' was not declared in this scope" #3046

merged 1 commit into from Sep 4, 2022

Conversation

fsiegert
Copy link
Contributor

@fsiegert fsiegert commented Sep 2, 2022

In Archlinux with gcc 12.2.0 we see a compilation error that seems to come from a missing <ctime> include. More details can be found in https://aur.archlinux.org/packages/cvmfs#comment-879961.

This PR fixes the issue.

@cernvm-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the patch!

Please just move the include down below #include <cstring>

@fsiegert
Copy link
Contributor Author

fsiegert commented Sep 4, 2022

Thanks @jblomer, this is indeed more tidy and I have amended the commit. Hope it's fine now!

@jblomer
Copy link
Member

jblomer commented Sep 4, 2022

@cernvm-bot unittest

@jblomer
Copy link
Member

jblomer commented Sep 4, 2022

@cernvm-bot cpplint

Copy link
Member

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@jblomer jblomer merged commit 0f43f5e into cvmfs:devel Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants