Skip to content

Commit

Permalink
Changed interaction with HTTPResponse in HTTPClient.
Browse files Browse the repository at this point in the history
  • Loading branch information
tszolar committed May 13, 2014
1 parent ca5788c commit 9307fc4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
6 changes: 2 additions & 4 deletions lib/kosapi_client/http_client.rb
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
module KOSapiClient
class HTTPClient

def initialize(http_adapter, response_converter = ResponseConverter.new)
def initialize(http_adapter)
@http_adapter = http_adapter
@response_converter = response_converter
end

def send_request(verb, url, options = {})
response = @http_adapter.send_request(verb, url, options)
#response.offset = options[:offset]
@response_converter.process_response(response)
response.convert
end


Expand Down
6 changes: 3 additions & 3 deletions spec/kosapi_client/http_client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

describe KOSapiClient::HTTPClient do

let(:response_converter) { instance_double(KOSapiClient::ResponseConverter, process_response: nil) }
let(:response) { instance_double(KOSapiClient::HTTPResponse, convert: nil) }
let(:http_adapter) { instance_double(KOSapiClient::OAuth2HttpAdapter) }
subject(:client) { KOSapiClient::HTTPClient.new(http_adapter, response_converter) }
subject(:client) { KOSapiClient::HTTPClient.new(http_adapter) }

describe '#send_request' do

it 'calls http adapter' do
expect(http_adapter).to receive(:send_request)
expect(http_adapter).to receive(:send_request).and_return(response)
client.send_request(:get, 'http://example.com')
end

Expand Down

0 comments on commit 9307fc4

Please sign in to comment.