Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default option when holding the screenshot button to skip the confirmation popup #376

Closed
wants to merge 1 commit into from

Conversation

cabiste69
Copy link
Contributor

@cabiste69 cabiste69 commented Sep 2, 2023

An attempt at adding a default action for holding the screenshot button in the quick access menu to skip the confirmation popup

@cvzi cvzi self-assigned this Sep 7, 2023
@cvzi cvzi self-requested a review September 7, 2023 20:11
@cvzi
Copy link
Owner

cvzi commented Sep 21, 2023

Sorry, I don't really understand what it should do, could you explain again?

@cabiste69
Copy link
Contributor Author

Hi, sorry i got busy a bit, this is basically an attempt at adding a default action when holding the screenshot button in the quick access menu.

By default when holding the screenshot button a popup will appear and ask you to pick a delay, i want to add an option to skip that and use whatever the user pre-defines

@cabiste69 cabiste69 changed the title Skip the "pick delay popup" when taking a partial screenshot Add a default option when holding the screenshot button to skip the confirmation popup Sep 25, 2023
@cvzi
Copy link
Owner

cvzi commented Sep 26, 2023

Ok, I understand now 👍

Maybe just write a note here, when/if you do continue to work on it.

I might work on it myself, but I am not sure when I will have time.

@cabiste69
Copy link
Contributor Author

hopefully can continue next week or so as i got a bit busy

@cvzi
Copy link
Owner

cvzi commented Oct 12, 2023

I think I'll add an option in the settings to select what happens when the button is long pressed, similar to the setting "Tile action" in the settings.

"Tile long-press action" options could be:

  • show popup dialog (current behaviour)
  • take screenshot
  • take partial screenshot
  • take screenshot 1s delay
  • take screenshot 2s delay
  • take screenshot 5s delay
  • toggle floating button

@cabiste69
Copy link
Contributor Author

yeah that's what i was going for, also was thinking of adding user defined delay time. sorry i couldn't do it as i got busy and i'm not very familiar with android development

@cvzi
Copy link
Owner

cvzi commented Oct 14, 2023

No worries, I'll implement it.

The code-base of this project is chaotic anyway...

@cvzi
Copy link
Owner

cvzi commented Oct 15, 2023

I manually merged this in 9aecec1 as a starting point

@cvzi
Copy link
Owner

cvzi commented Oct 26, 2023

There is now an option the settings "Tile long-press action"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants