Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New genius.com page design #4

Closed
cvzi opened this issue Mar 19, 2020 · 3 comments
Closed

New genius.com page design #4

cvzi opened this issue Mar 19, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cvzi
Copy link
Owner

cvzi commented Mar 19, 2020

Apparently genius.com is phasing in a new page design. This will break the "Spotify theme" completely. Parts of the "Genius theme" are also broken.

if (html.indexOf('class="lyrics">') === -1) {
let originalUrl = ''
try {
const doc = getDOMParser().parseFromString(html, 'text/html')
originalUrl = doc.querySelector('meta[property="og:url"]').content
} catch (e) {
}
window.alert(scriptName + ':\nThese lyrics use the new genius design. They cannot be shown with the "Spotify theme" yet.\n\n' + originalUrl)
return
}

@Shazgul
Copy link

Shazgul commented Dec 22, 2022

Error: Unknown genius page design
Genius: https://genius.com/Omik-k-kamikaze-lyrics

@cvzi cvzi reopened this Dec 22, 2022
@cvzi
Copy link
Owner Author

cvzi commented Dec 22, 2022

Thanks for the report!

We are doing some major updates to the script at the moment. I think that will resolve the problem

@cvzi
Copy link
Owner Author

cvzi commented Dec 23, 2022

This should be fixed now. The script will now ignore these results like https://genius.com/Omik-k-kamikaze-lyrics that say "Lyrics for this song have yet to be released"

@cvzi cvzi closed this as completed Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants