Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete lyrics when selecting "Clean White" or "Spotify" theme #62

Closed
i486 opened this issue Nov 3, 2023 · 5 comments
Closed

Incomplete lyrics when selecting "Clean White" or "Spotify" theme #62

i486 opened this issue Nov 3, 2023 · 5 comments

Comments

@i486
Copy link

i486 commented Nov 3, 2023

"Clean white" incomplete lyrics

image

"Genius Default" works but font size is too small.

image

Firefox: 115.4.0esr (64-bit)

@cyfung1031
Copy link
Collaborator

@cvzi any idea regarding the incomplete lyrics in white / spotify theme ? seem the lyrics is removed in the html code.

@cyfung1031
Copy link
Collaborator

cyfung1031 commented Nov 11, 2023

@i486

  1. Right click the lyrics, click inspect. in the opened DevTools, type ((s)=>{console.log(s.fontFamily, s.fontSize)})(getComputedStyle(document.querySelector('#lyrics-root')||$0)); in the console and press enter. copy the message and post it here.

  2. What is your OS ? Mac? Windows 11? Guess it is a font issue with the system.

@i486
Copy link
Author

i486 commented Nov 12, 2023

@i486

1. Right click the lyrics, click inspect.  in the opened DevTools, type `((s)=>{console.log(s.fontFamily, s.fontSize)})(getComputedStyle(document.querySelector('#lyrics-root')||$0));` in the console and press enter. copy the message and post it here.

2. What is your OS ? Mac? Windows 11? Guess it is a font issue with the system.

Clean White
"Youtube Sans", Roboto, Arial, sans-serif 16px

Spotify (also incomplete lyrics)
CircularSp, CircularSp-Arab, CircularSp-Hebr, CircularSp-Cyrl, CircularSp-Grek, CircularSp-Deva, "HelveticaNeue", Arial, sans-serif 16px

On Windows 7 x64, an admittedly outdated OS, I'm hoping that the script could be adjusted to resolve this issue. However, I am willing to install any required fonts myself if fixing it through the script is not worthwhile.

@cyfung1031
Copy link
Collaborator

@i486

1. Right click the lyrics, click inspect.  in the opened DevTools, type `((s)=>{console.log(s.fontFamily, s.fontSize)})(getComputedStyle(document.querySelector('#lyrics-root')||$0));` in the console and press enter. copy the message and post it here.

2. What is your OS ? Mac? Windows 11? Guess it is a font issue with the system.

Clean White "Youtube Sans", Roboto, Arial, sans-serif 16px

Spotify (also incomplete lyrics) CircularSp, CircularSp-Arab, CircularSp-Hebr, CircularSp-Cyrl, CircularSp-Grek, CircularSp-Deva, "HelveticaNeue", Arial, sans-serif 16px

On Windows 7 x64, an admittedly outdated OS, I'm hoping that the script could be adjusted to resolve this issue. However, I am willing to install any required fonts myself if fixing it through the script is not worthwhile.

I mean the fonts and size for Genius(Default) theme. For YouTube Genius Lyrics, clean white and spotify theme are not recommended.

cvzi added a commit to cvzi/genius-lyrics-userscript that referenced this issue Nov 15, 2023
when selecting "Clean White" or "Spotify" theme
cvzi/Youtube-Genius-Lyrics-userscript#62

There are multiple "Lyrics__Container" on genius.com now for longer lyrics
@cvzi
Copy link
Owner

cvzi commented Nov 15, 2023

Should be fixed now.

Problem was that genius.com has now multiple div.Lyrics__Container that contain the lyrics if the lyrics are long. Previously it was just one div

@cvzi cvzi closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants