Merge pull request #249 from drupol/use-strict-comparison

Use strict comparison.
cweagans · Feb 14, 2019 · 17fe176 · 17fe176
2 parents d8a38a5 + 7efcf96
commit 17fe176
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/Plugin/Patches.php b/src/Plugin/Patches.php
@@ -208,7 +208,7 @@ public function resolvePatches(PackageEvent $event)
         // Let each resolver discover patches and add them to the PatchCollection.
         /** @var ResolverInterface $resolver */
         foreach ($this->getPatchResolvers() as $resolver) {
-            if (!in_array(get_class($resolver), $this->getConfig('disable-resolvers'))) {
+            if (!in_array(get_class($resolver), $this->getConfig('disable-resolvers'), true)) {
                 $resolver->resolve($this->patchCollection, $event);
             } else {
                 if ($this->io->isVerbose()) {
@@ -247,7 +247,7 @@ public function checkPatches(Event $event)
                 $tmp_patches = Util::arrayMergeRecursiveDistinct($tmp_patches, $patches);
             }
 
-            if ($tmp_patches == false) {
+            if ($tmp_patches === false) {
                 $this->io->write('<info>No patches supplied.</info>');
                 return;
             }
@@ -404,7 +404,7 @@ protected function getAndApplyPatch(RemoteFilesystem $downloader, $install_path,
                 $filename
             );
             $output = $this->executor->getErrorOutput();
-            if (substr($output, 0, 7) == 'Skipped') {
+            if (substr($output, 0, 7) === 'Skipped') {
                 // Git will indicate success but silently skip patches in some scenarios.
                 //
                 // @see https://github.com/cweagans/composer-patches/pull/165
@@ -462,7 +462,7 @@ protected function isPatchingEnabled()
         $enabled = true;
 
         $has_no_patches = empty($extra['patches']);
-        $has_no_patches_file = ($this->getConfig('patches-file') == '');
+        $has_no_patches_file = ($this->getConfig('patches-file') === '');
         $patching_disabled = $this->getConfig('disable-patching');
 
         if ($patching_disabled || !($has_no_patches && $has_no_patches_file)) {
@@ -495,13 +495,13 @@ protected function executeCommand($cmd)
             $this->io->write('<comment>' . $command . '</comment>');
             $io = $this->io;
             $output = function ($type, $data) use ($io) {
-                if ($type == Process::ERR) {
+                if ($type === Process::ERR) {
                     $io->write('<error>' . $data . '</error>');
                 } else {
                     $io->write('<comment>' . $data . '</comment>');
                 }
             };
         }
-        return ($this->executor->execute($command, $output) == 0);
+        return ($this->executor->execute($command, $output) === 0);
     }
 }
diff --git a/src/Resolvers/DependencyPatches.php b/src/Resolvers/DependencyPatches.php
@@ -27,7 +27,7 @@ public function resolve(PatchCollection $collection, PackageEvent $event)
 
         $operations = $event->getOperations();
         foreach ($operations as $operation) {
-            if ($operation->getJobType() == 'install' || $operation->getJobType() == 'update') {
+            if ($operation->getJobType() === 'install' || $operation->getJobType() === 'update') {
                 // @TODO handle exception.
                 $package = $this->getPackageFromOperation($operation);
                 /** @var PackageInterface $extra */

diff --git a/src/Resolvers/PatchesFile.php b/src/Resolvers/PatchesFile.php
@@ -57,7 +57,7 @@ protected function readPatchesFile($patches_file)
 
         // First, check for JSON syntax issues.
         $json_error = json_last_error_msg();
-        if ($json_error != "No error") {
+        if ($json_error !== "No error") {
             throw new \InvalidArgumentException($json_error);
         }