Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master: Patches are not being installed from dependencies #322

Closed
mxr576 opened this issue Jul 23, 2020 · 4 comments
Closed

Master: Patches are not being installed from dependencies #322

mxr576 opened this issue Jul 23, 2020 · 4 comments

Comments

@mxr576
Copy link

mxr576 commented Jul 23, 2020

Composer 2 support was added to master with #309. I am trying to use that on our projects but I have just noticed that patches from dependencies are not being installed, even if "enable-patching": true, is set.

The issue seems unrelated to #309, it looks like that was broken even before that.

Related: #313

@cweagans
Copy link
Owner

#267

@mxr576
Copy link
Author

mxr576 commented Jul 24, 2020

Ahh, I see... Thanks for the info. I understand the security implications of this, but we had a metapackage that installed necessary patches on projects that we worked on. Now, with the new PatchResolver approach, we have to write our own plugin to make this work again.

@cweagans
Copy link
Owner

That's true. I wouldn't recommend using master for anything important right now though. Use 1.x (which still includes this functionality).

@cweagans
Copy link
Owner

Also, I'm planning on writing the plugin that does this as part of the 2.x release series, but it's just not important to the core functionality of this plugin right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants