Make compatible with Composer 2

[balsama]

Drupal aims to be compatible with Composer 2. See Issue #3126566.

As one of the most widely used plugins in Drupal, we should aim to make this plugin compatible with Composer 2 too.

[cweagans]

see also #309

definitely in favor of this.

[balsama]

Oh dang. I missed that when I searched for an existing issue because I wasn't searching PRs (shakes fist at github defaults).

Perhaps we should leave this open then for others who might do the same. Thanks.

[mxr576]

When do you plan to release a new version with Composer 2.x support? As I can see it is only available in master yet.

[mxr576]

Hm, and why master is not the alias of 1.x-dev? 🤔
https://packagist.org/packages/cweagans/composer-patches#1.x-dev
https://packagist.org/packages/cweagans/composer-patches#dev-master

[NetStorm84]

I would also like compatibility with Composer 2. Do we have an idea when this is likely to happen?

[hussainweb]

I created a PR #321 to add support for Composer 2 to the 1.x branch. It's basically a cherry-pick from #309 and then changes to composer.lock (which I was not sure about).

[danepowell]

If I'm not mistaken this was added in #321

Can we get a new stable release so end users can start using Composer 2?

[hussainweb]

@danepowell, we would also need #330 to go in before this works with composer 2.

[clxmstaab]

you could already beta-test composer v2 support with a constraint like

"cweagans/composer-patches": "1.x-dev as 1.6.8-dev",

one issue we ran into when using the plugin with composer-v2 is

Fatal error: Uncaught Error: Call to undefined method Composer\DependencyResolver\Operation\InstallOperation::getJobType() in /home/runner/work/daiber/daiber/vendor/cweagans/composer-patches/src/Patches.php:179
Stack trace:
#0 [internal function]: cweagans\Composer\Patches->gatherPatches()
#1 phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php(165): call_user_func()
#2 phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php(118): Composer\EventDispatcher\EventDispatcher->doDispatch()
#3 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(368): Composer\EventDispatcher\EventDispatcher->dispatchPackageEvent()
#4 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(309): Composer\Installer\InstallationManager->executeBatch()
#5 phar:///usr/local/bin/composer/src/Composer/Installer.php(711): Composer\Installer\InstallationManager->execute()
#6 phar:///usr/local/bin/composer/src/Composer/Installer.php(252): Composer\Installer in /home/runner/work/daiber/daiber/vendor/cweagans/composer-patches/src/Patches.php on line 179

for a first step I just added some automation using phpstan and phpunit run by a github action

would love to get some support to hunt down remainig problems on the road to composer v2 support

[markdorison]

@clxmstaab I believe that issue is addressed in PR #330.

[balsama]

#330 was merged into 1.x: ae02121

[balsama]

As of 1.7.0, this is fixed. Thanks!