Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dependency patches #113

Closed
wants to merge 1 commit into from

Conversation

dmsmidt
Copy link

@dmsmidt dmsmidt commented Mar 7, 2017

this commit fixes #112

@dmsmidt
Copy link
Author

dmsmidt commented Mar 7, 2017

Note that this only works without the intermediate level (below: drupal/lightning).
I think that abstraction is not really needed and keeping the structure similar to "patches" makes it easier to use.

Before:

"patches-ignore": {
      "drupal/lightning": {
        "drupal/panelizer": {
          "This patch has known conflicts with our Quick Edit integration": "https://www.drupal.org/files/issues/2664682-49.patch"
        }
      }
    }
  }

After:

"patches-ignore": {
  "drupal/panelizer": {
    "This patch has known conflicts with our Quick Edit integration": "https://www.drupal.org/files/issues/2664682-49.patch"
    }
  }
}

Note, no cleanup of the code mentioned in #112 is done.

@dmsmidt
Copy link
Author

dmsmidt commented Mar 9, 2017

Actually this change only sees to work for tag 1.6.0, master doesn't apply patches anyhow.

@dmsmidt
Copy link
Author

dmsmidt commented Mar 14, 2017

That patches didn't apply is fixed being here in #108. Closing this since we want a PR for master.

@dmsmidt dmsmidt closed this Mar 14, 2017
@dmsmidt dmsmidt deleted the ignore-dependency-patches branch March 14, 2017 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignoring patches from dependencies doesn't work
1 participant