Exit on patch failure should use composer extra, not localPackage #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under error handling, two mechanisms are given for halting on patch failure: setting an environment variable and adding an option to the extra section of composer.json. But only the first works - the composer.json setting does not work, or at least does not work as described.
It seems that the code is looking for the extra setting in $localPackage->getExtra() whereas I think it should be looking in the root composer.json $this->composer->getPackage()->getExtra().
This pull request changes the behavior to look only at the root. I am making the assumption that the root should take precedence over localPackage -- once could argue, I guess, that both should be consulted but since one major purpose of this setting is continuous integration, I think it probably expected that the root composer.json is the one that controls CI work flow and should be preferred.