Add support for Promises being returned by uninstall in Composer 2.1 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to resolve the issue following the steps in #363 (comment), although I only applied the changes manually after running |
|
Thanks 👍🏻 Older versions return null instead of a promise, so array_filter should just return an empty array and the behavior will not be altered. |
This was referenced Jun 8, 2021
Closed
|
Thank you for this, @Seldaek! Really, really appreciate it!! |
This was referenced Jun 9, 2021
Merged
Merged
Merged
Closed
Merged
alenalato
added a commit
to Hevelop/composer-patches
that referenced
this pull request
Jul 16, 2021
Add support for Promises being returned by uninstall in Composer 2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363 I hope :)
See also #366 for a version of this PR targetting 1.x