Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated tests, require PHP 8 #428

Merged
merged 5 commits into from Dec 20, 2022
Merged

Add automated tests, require PHP 8 #428

merged 5 commits into from Dec 20, 2022

Conversation

danepowell
Copy link
Collaborator

@danepowell danepowell commented Dec 19, 2022 •
edited

  • Travis CI is no longer reliable or secure (or working at all in the case of this project). Use GitHub Actions for automated tests instead.
  • Require PHP 8 for the 2.x release (it's just too hard to continue to support PHP 7 for local dev and CI)

I still need to fix the unit and acceptance tests to support Composer 2.

@cweagans any qualms about requiring PHP 8 for the 2.x release or switching to GitHub Actions (free for public projects like this)?

@danepowell danepowell changed the title Add automated tests Add automated tests, require PHP 8 Dec 19, 2022
@danepowell danepowell mentioned this pull request Dec 19, 2022
Closed
@cweagans
Copy link
Owner

any qualms about requiring PHP 8 for the 2.x release or switching to GitHub Actions (free for public projects like this)?

Nope! I'm generally okay with dropping support for EOL PHP versions -- even in 1.x, though that would likely need some planning/comms.

@danepowell danepowell merged commit e2fedb8 into cweagans:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danepowell @cweagans