Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composer and io to all events + emit event before throwing exception when patch does not apply #470

Merged
merged 8 commits into from Feb 12, 2023
Merged

Add composer and io to all events + emit event before throwing exception when patch does not apply #470

merged 8 commits into from Feb 12, 2023

Conversation

cweagans
Copy link
Owner

Description

Relates to/closes #issueID.

Related tasks

  • Documentation has been updated if applicable
  • Tests have been added
  • Does not break backwards compatibility OR a BC break has been discussed in the related issue(s).

Other notes

@cweagans
Copy link
Owner Author

cweagans commented Feb 12, 2023 •
edited

cc @waleedq @moerazem @Natshah

Note that this is not in the 1.x branch nor will it be in a 1.x release. This will be in 2.0.0 when it's out. Follow #451 for progress.

@coveralls
Copy link

coveralls commented Feb 12, 2023 •
edited

Pull Request Test Coverage Report for Build 4154978819

  • 18 of 24 (75.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 86.146%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Plugin/Patches.php 5 11 45.45%
Totals Coverage Status
Change from base Build 4154832704: -0.2%
Covered Lines: 485
Relevant Lines: 563
💛 - Coveralls

@cweagans cweagans changed the title Add composer and io to all events Add composer and io to all events + emit event before throwing exception when patch does not apply Feb 12, 2023
@cweagans
Patch debug output only shows up when --debug is passed to codecept, …
e317b8c 
…so we cannot count on that in the composer output
@cweagans cweagans merged commit 460f1e6 into main Feb 12, 2023
@cweagans cweagans deleted the add-composer-and-io-to-events branch February 12, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cweagans @coveralls @waleedq