Add new patcher: git 'init' patcher #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4158688379
💛 - Coveralls |
This was referenced Feb 13, 2023
Closed
|
|
||
| $this->io->write("Creating temporary fake git repo in $path to apply patch", true, IOInterface::VERBOSE); | ||
|
|
||
| // Create a fake Git repo -- just enough to make Git think it's looking at a real repo. |
There was a problem hiding this comment.
👋
I think by not calling git init that it relies too much on the internal implementation of the .git directory. What if a later version requires some fourth file?
I suppose if this is documented somewhere by git it would be OK.
There was a problem hiding this comment.
I think you're right. Changed this to just use git init in a14cba7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
githas historically been the most reliable mechanism for applying patches. Unfortunately, it doesn't work at all when the target directory isn't a git repo. This pull request adds a new patcher that creates a fake (minimal) git repository in the target directory, uses git to apply the patch, and then cleans up the fake git repo.Related tasks
Other notes
@deviantintegral I'm very curious about your thoughts on this one since you did most of the original debugging around why
gitwas misbehaving. (composer installthen./vendor/bin/codecept run tests/acceptance/ApplyGitPatchFromWebUsingInitCept.php --debugif you want to play with this locally) -- I merged #472 but we can revert if needed.If this approach works, I'm really considering #472 as a path forward. Git handles a lot of things that people have asked for over the year. It's also a lot easier to support -- "Go install
git" is easier to communicate than "Go installpatch... no, thepatchthat came with your system is unusable and you need to install this other thing that is named exactly the same but provides different functionality"