Small Pythonisms

[kmanc]

Huge fan of your work!

Just tossed in a few things that might make it easier for you going forward. Namely f-strings in a few places and the "X if X else Y" pattern replaced with "X or Y" which is more concise :)

[cwendt94]

Thanks this is really helpful! Looks like one test is failing because of the f-string and numbers for football/box_player

[kmanc]

I'll take a look and undo the damage later today, my bad!

[cwendt94]

I'll take a look and undo the damage later today, my bad!

No worries, just a small update to the test case! Just need to update this line https://github.com/cwendt94/espn-api/blob/master/tests/football/integration/test_league.py#L43 with the decimal points

[kmanc]

Cool so I learned how to run the tests! I wasn't giving unittest the "discover" flag so now that I am I can actually run the tests and get the output =D

[codecov-commenter]

Codecov Report

Merging #265 (2738688) into master (85d58e4) will not change coverage.
The diff coverage is 51.72%.

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          46       46           
  Lines        1616     1616           
=======================================
  Hits         1416     1416           
  Misses        200      200           

Impacted Files	Coverage Δ
espn_api/base_settings.py	100.00% <ø> (ø)
espn_api/baseball/box_score.py	52.08% <0.00%> (ø)
espn_api/baseball/team.py	97.72% <0.00%> (ø)
espn_api/basketball/box_score.py	89.65% <0.00%> (ø)
espn_api/basketball/matchup.py	87.50% <0.00%> (ø)
espn_api/basketball/player.py	96.15% <0.00%> (ø)
espn_api/hockey/box_score.py	86.20% <ø> (ø)
espn_api/hockey/record.py	20.00% <ø> (ø)
espn_api/basketball/box_player.py	96.29% <50.00%> (ø)
espn_api/basketball/team.py	97.87% <50.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85d58e4...2738688. Read the comment docs.