Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for wnba basketball #332

Merged
merged 3 commits into from May 11, 2022
Merged

added support for wnba basketball #332

merged 3 commits into from May 11, 2022

Conversation

zwebb2
Copy link

@zwebb2 zwebb2 commented May 8, 2022

Added a new league type that enables support for wnba basketball, including a working PRO_TEAM_MAP for wnba teams in the constants.py file.

Copy link
Owner

@cwendt94 cwendt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for adding wnba league!

two small notes

  1. can you remove import pdb from the python files
  2. would you be able to right a small integration test for this league like basketball. The folder can be wbasketball. You will just need a public league that you can use for testing.

@zwebb2
Copy link
Author

zwebb2 commented May 10, 2022

I removed the pdb imports as well. Note that this league has only been running for a few days, so the assertions in the tests will fail after today, and need to be updated with correct values after the end of the season.

@cwendt94
Copy link
Owner

You can comment out the tests that are checking current stats so that they won't fail.

These tests are mainly used to check that you can still load a WNBA league without errors.

I can add some more tests in the future.

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #332 (8700c8e) into master (29d3467) will decrease coverage by 4.91%.
The diff coverage is 57.54%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   87.82%   82.91%   -4.92%     
==========================================
  Files          47       56       +9     
  Lines        1643     1961     +318     
==========================================
+ Hits         1443     1626     +183     
- Misses        200      335     +135     
Impacted Files Coverage Δ
espn_api/requests/constant.py 100.00% <ø> (ø)
espn_api/wbasketball/box_score.py 13.79% <13.79%> (ø)
espn_api/wbasketball/activity.py 18.18% <18.18%> (ø)
espn_api/wbasketball/box_player.py 22.22% <22.22%> (ø)
espn_api/wbasketball/league.py 48.80% <48.80%> (ø)
espn_api/wbasketball/matchup.py 86.95% <86.95%> (ø)
espn_api/wbasketball/player.py 91.66% <91.66%> (ø)
espn_api/wbasketball/team.py 97.82% <97.82%> (ø)
espn_api/wbasketball/__init__.py 100.00% <100.00%> (ø)
espn_api/wbasketball/constant.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d3467...8700c8e. Read the comment docs.

@cwendt94
Copy link
Owner

After the first matchup is finished we can add some tests to the different components to get better coverage on this league.

@cwendt94 cwendt94 merged commit 7b3b873 into cwendt94:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants