Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding type annotation for the scoreboard method #467

Merged
merged 3 commits into from Oct 2, 2023

Conversation

spkane31
Copy link
Contributor

@spkane31 spkane31 commented Sep 21, 2023

This PR adds a Team type annotation for the Matchup class. Currently, the id is written (as an int) and then in a loop it is dynamically changed to a Team. I made a change to store the id in a separate variable _{home,away}_team_id and then uses that variable in the loop to set the team. I noticed this 'issue' while working in VS Code and the type annotation wasn't populating, this should make for a slightly improved developer experience

@spkane31
Copy link
Contributor Author

I tested this locally to confirm it does not contain any breaking changes to functionality, only adding a new member variable

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (81f8967) 80.36% compared to head (81d853a) 80.36%.
Report is 13 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   80.36%   80.36%   -0.01%     
==========================================
  Files          60       60              
  Lines        2109     2114       +5     
==========================================
+ Hits         1695     1699       +4     
- Misses        414      415       +1     
Files Changed Coverage Δ
espn_api/football/league.py 94.52% <100.00%> (ø)
espn_api/football/matchup.py 94.11% <100.00%> (+1.26%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwendt94
Copy link
Owner

cwendt94 commented Oct 2, 2023

Looks good, thanks for adding this!

@cwendt94 cwendt94 merged commit 8186275 into cwendt94:master Oct 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants