Edge case "None" owners fix #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 60 60
Lines 2209 2209
=======================================
Hits 1790 1790
Misses 419 419 ☔ View full report in Codecov by Sentry. |
|
Good catch! |
|
When you run it multiple times a week against several hundred leagues, you find edge cases fast lol. Thanks for the merge and release. |
|
I bet lol, that is very helpful! Thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #518
Fixes edge case, where if team has the key 'owners' but its value is None or an empty list, this will raise an IndexError. It will now properly make an empty list with an indexable [0] element