Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize to support more than just football #73

Merged
merged 17 commits into from
Oct 31, 2019

Conversation

bsmiller25
Copy link
Contributor

Summary:

  • Move football to own submodule
  • Create basketball submodule

Known issues:

  • utils.py could probably live a level higher and be shared instead of duplicated across football and basketball
  • README out of date
  • my suggested documentation for usage would be avoiding namespace issues is:
import espn_api.football as football  
league = football.league(...)

and

import espn_api.basketball as bball
league = bball.league(...)
  • There are a lot of basketball stats in constant.py and I couldn't figure them all out.
  • I've only written this based on my head to head categories league. Probably need to change a bit to handle different scoring formats.
  • Overall, basketball has much less functionality than football but I think this is a decent start!

@bsmiller25 bsmiller25 mentioned this pull request Oct 26, 2019
@bsmiller25
Copy link
Contributor Author

I also recommend renaming this repo from ff-espn-api to espn-api or something without ff in it

@codecov-io
Copy link

codecov-io commented Oct 27, 2019

Codecov Report

Merging #73 into develop will decrease coverage by 23.17%.
The diff coverage is 24.59%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #73       +/-   ##
============================================
- Coverage    98.96%   75.79%   -23.18%     
============================================
  Files           13       21        +8     
  Lines          578      822      +244     
============================================
+ Hits           572      623       +51     
- Misses           6      199      +193
Impacted Files Coverage Δ
espn_api/football/utils.py 100% <ø> (ø)
espn_api/football/constant.py 100% <ø> (ø)
espn_api/football/settings.py 100% <ø> (ø)
espn_api/football/player.py 100% <ø> (ø)
espn_api/football/activity.py 100% <ø> (ø)
espn_api/football/pick.py 100% <ø> (ø)
espn_api/football/__init__.py 100% <ø> (ø)
espn_api/football/box_score.py 100% <ø> (ø)
espn_api/basketball/logger.py 25% <ø> (ø)
espn_api/football/matchup.py 100% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e7cf8b...72909cc. Read the comment docs.

@cwendt94 cwendt94 merged commit 72909cc into cwendt94:develop Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants