Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for merge pipe assembly that throws PlannerException #44

Closed
wants to merge 4 commits into from

Conversation

pushpak-gohey
Copy link

Added test case for merge pipe assembly that throws below PlannerException-

cascading.flow.planner.PlannerException: union of steps have 3 fewer elements than parent assembly: MapReduceHadoopRuleRegistry, missing: [Hfs["TextDelimited[['f1', 'f2', 'f3']]"]["../cascading-platform/src/test/resources/data/delimited-file1.txt"], Every(GroupBy Pipe 1)[First[decl:ARGS]], GroupBy(GroupBy Pipe 1)[by:[{1}:'f1']]]

Following is the scenario being tested with 2 '|' delimited input files having 3 fields f1, f2,f3-
Input file1 --> GroupBy(on f1) --> Every(First()) --> Merge() --> Output
Input file2 --> GroupBy(on f1) --> Every(First()) -->

Updated to cascading-wip-3.0.2
PlannerException: union of steps have 3 fewer elements than parent
assembly
FileAlreadyExistsException for Merge pipe assembly.
Added test in MergePipeAssemblyTest.java that throws FileAlreadyExistsException.
@cwensel
Copy link
Owner

cwensel commented Nov 30, 2015

Ok, so you are making multiple distinct pull requests from the same branch. And since your pull requests are not a single commit, its difficult to patch them back together.

please make a clean branch per pull request, and submit them. preferably without what I think is an alternate history to my own repo (i’m seeing lots of merges etc from within your cloned repo, i think).

please close and resubmit.

@cwensel
Copy link
Owner

cwensel commented Nov 30, 2015

ok turns out they are single commits, just a few merge branches bookending everything, i’m looking at ae6b04e now.

@cwensel
Copy link
Owner

cwensel commented Nov 30, 2015

I can reproduce this, and it turns out in some variations a file already exists exception is thrown.

if I can get a fix, will run regressions and push the changes monday.

@cwensel
Copy link
Owner

cwensel commented Dec 2, 2015

please try version 3.1-wip-41 and let me know if this is resolved.

@pushpak-gohey
Copy link
Author

Hi Chris,

The issue is resolved in 3.1-wip-41 version.

Thanks,
Pushpak D Gohey

On Thu, Dec 3, 2015 at 1:11 AM, Chris K Wensel notifications@github.com
wrote:

please try version 3.1-wip-41 and let me know if this is resolved.


Reply to this email directly or view it on GitHub
#44 (comment).

@cwensel cwensel closed this Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants