Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer doesn't differentiate different node installations #8

Open
cwernert opened this issue Oct 3, 2022 · 3 comments
Open

Installer doesn't differentiate different node installations #8

cwernert opened this issue Oct 3, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@cwernert
Copy link
Owner

cwernert commented Oct 3, 2022

MacOS can have node in various spots, and it looks like (verify) SwiftBar requires it to be in the standard dir:
/usr/local/bin/node
If Node is installed via NVM, it will be at:
~/.nvm/versions/node

Need to:

  • Verify that swiftbar needs node in the standard dir
  • Update the installer to check for and enforce this
@cwernert cwernert added the bug Something isn't working label Oct 3, 2022
@cwernert cwernert self-assigned this Oct 3, 2022
@cwernert
Copy link
Owner Author

cwernert commented Oct 3, 2022

Might be able to do this simply by expecting this result from which node:
/usr/local/bin/node

@cwernert
Copy link
Owner Author

cwernert commented Oct 3, 2022

Also not sure if relevant, but the shebang seems to be the reason the plugin throws an error - maybe this could be set dynamically?
#!/usr/bin/env /usr/local/bin/node

@cwernert
Copy link
Owner Author

cwernert commented Oct 4, 2022

I reduced the specificity of the shebang on both node js files, so that instead of referring to node with an absolute path, it now relies on env finding the user's node installation. Dayne will test this when reinstalling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant