Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import spark session implicits #25

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

cwienberg
Copy link
Owner

This rules out any possibility of invoking an unintended implicit.

@codecov-commenter
Copy link

Codecov Report

Merging #25 (bfaf807) into main (2e530b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   99.67%   99.68%           
=======================================
  Files          10       10           
  Lines         310      315    +5     
  Branches        6        6           
=======================================
+ Hits          309      314    +5     
  Misses          1        1           
Impacted Files Coverage Δ
...ting/SecondarySortGroupByKeyDatasetFunctions.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwienberg cwienberg merged commit b3dd37d into main Aug 26, 2022
@cwienberg cwienberg deleted the feature/dont-import-spark-session-implicits branch August 26, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants