-
Notifications
You must be signed in to change notification settings - Fork 28
backspacing problem #8
Comments
Thanks for the report, I will take a look! On Thu, Jan 14, 2016, at 10:41 PM, Didier Baquier wrote:
Links: |
Thanks for the quick answer Cameron. I updated the issue with my findings. |
Yeah lemme play around with it some. If it works I'll ask you to open the PR. |
hey Cameron, any updates on this one? |
Hey yeah. Your change looks good to me. Do you want to open a PR or do you want me to change it? |
Thanks for merging the PR, are you going to push https://github.com/cwill747/angular-libphonenumber/milestones/v0.0.9 anytime soon? |
Done! |
Overview of the Issue
![screen shot 2016-01-14 at 7 31 23 pm](https://cloud.githubusercontent.com/assets/1867703/12344757/a7315d1e-baf5-11e5-9ce2-42a363403aac.png)
![screen shot 2016-01-14 at 7 31 33 pm](https://cloud.githubusercontent.com/assets/1867703/12344754/9fce79c6-baf5-11e5-8a31-dc2abc41abd0.png)
When using the singapore country code ("sg") and entering
012345
, the backspace key works fine to remove the 5 but then got stuck and cannot remove01234
.Angular Version: v1.4.3
Angular libphonenumber Version: 0.0.7
Browsers and Operating System: Able to reproduce on chrome and on mobile devices via cordova
Reproduce the Error: just run the basic example with singapore country code, enter 012345 then try to delete.
Suggest a Fix: I was not able to isolate the part of the code yet.
Thanks for your help!
EDIT 1: By triming the returned value of the clean function, the problem disappears. Replace that line (https://github.com/cwill747/angular-libphonenumber/blob/master/src/phone-number.js#L91) by:
Before opening a PR, I would like to know your thoughts on the issue and make sure it won't cause any regression. Thanks
The text was updated successfully, but these errors were encountered: