Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0384/cr-keyconfig] キーコンフィグ周りのコード整理 #1018

Merged
merged 3 commits into from Mar 11, 2021

Conversation

cwtickle
Copy link
Owner

@cwtickle cwtickle commented Mar 11, 2021

🔨 変更内容 / Details of Changes

  1. キーコンフィグ周りのコードを整理しました。
    • resetCursor, setKeyConfigCursor関数の引数を整理し、冗長な引数をカット。keyConfigInit配下に配置。
    • resetCursorMain, resetCursorReplaced, resetCursorALL関数を廃止。
      直接resetCursorを呼び出すように変更。
    • カーソル移動用の関数としてsearchNextCursor関数を切り出し。
    • 二重定義箇所を見直し、基本的にkeyConfigInitで定義した変数を利用するように変更。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. [0376/code-refactoring] キーコンフィグ画面内のeval関数を排除 #1006 にてeval関数を削除したが、構造的にあまり変わっておらずコードの見通しが悪いため。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

@codeclimate
Copy link

codeclimate bot commented Mar 11, 2021

Code Climate has analyzed commit 3c781d9 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant