[0420/asym-14key] Asym-Mirrorが適用できるように14keyにシャッフルグループを追加 #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 032c31c and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔨 変更内容 / Details of Changes
14key用のシャッフルグループを追加しました。
Group1を選択することで、「Asym-Mirror」が適用できるようになります。
※これまでのシャッフルグループは「Group2」です。
🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes
また、適用できないパターンをGroup2としてしまうと、直感的にわかりにくいため。
📷 スクリーンショット / Screenshot
📝 その他コメント / Other Comments
差異が少なくキーコンフィグ画面で確認できるため、大きな問題にはならないと考える。