Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: [0607] 左上のフレーム数表記をbaseFrameに変更 #1345

Merged
merged 1 commit into from Oct 30, 2022

Conversation

cwtickle
Copy link
Owner

@cwtickle cwtickle commented Oct 30, 2022

🔨 変更内容 / Details of Changes

  1. 左上のフレーム数表記をg_scroeObj.baseFrameに変更しました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. ver28.4.0よりこの左上のフレーム数はnominalFrameNumを採用していますが、本来は制作者が使うもののため、frameNumやnominalFrameNumよりbaseFrameを採用する方が自然と考えます。

📷 スクリーンショット / Screenshot

📝 その他コメント / Other Comments

@codeclimate
Copy link

codeclimate bot commented Oct 30, 2022

Code Climate has analyzed commit b85882a and detected 0 issues on this pull request.

View more on Code Climate.

@cwtickle cwtickle merged commit 3515301 into develop Oct 30, 2022
@cwtickle cwtickle deleted the feature/0607-frame-view branch October 31, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant