improve: [0646] divMaxX_Yが未定義の場合、配列の最大値を取るよう修正 #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ef66354 and detected 0 issues on this pull request. View more on Code Climate. |
This was referenced Feb 20, 2023
cwtickle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔨 変更内容 / Details of Changes
posX_Yの最大値＋１を取るように修正しました。
🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes
posX_Yの最終番目の値＋１をdivMaxX_Yとして定義していましたが、
トランスキーなどこれに当てはまらないケースが出てきたため、見直すことにしました。
📷 スクリーンショット / Screenshot
📝 その他コメント / Other Comments