improve: [0715] Difficultyを変更するごとにGaugeを初期化しないよう変更 #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit cb2f9d4 and detected 0 issues on this pull request. View more on Code Climate. |
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔨 変更内容 / Details of Changes
例えばGauge:「Hard」を選択し、Difficultyを変更した場合に
次の譜面のゲージ設定にGauge:「Hard」があれば、ゲージ設定を変更しません。
🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes
gaugeChange関数について、ゲージ設定配列を入れ替える処理とゲージ明細を設定する処理が一緒になっており、使いづらい処理になっていたため整理した上でsetGauge関数へ統合しました。📷 スクリーンショット / Screenshot
📝 その他コメント / Other Comments